tests/file_test.py:91

• The removal of the 'Bad Post Data' test case may leave an edge-case scenario uncovered. Consider adding an alternative test to ensure validation of posts with empty or missing fields is still tested.

"Bad Post Data": TestCase(

file.py (1)

37-38: Consider performance optimization for repeated file reads.

The function reads the golden file on every call, which could impact performance when validating many URLs. Consider caching the template content.

Here's a potential optimization using a module-level cache:

+# Cache for the golden file content
+_no_content_template_cache = None
+
+def _load_no_content_template():
+    """Load and cache the no content template."""
+    global _no_content_template_cache
+    if _no_content_template_cache is None:
+        current_dir = os.path.dirname(os.path.abspath(__file__))
+        golden_file_path = os.path.join(current_dir, "tests", "no_content_template.golden")
+        with open(golden_file_path, "r", encoding="utf-8") as nct:
+            _no_content_template_cache = nct.read()
+    return _no_content_template_cache

Then use no_content_template = _load_no_content_template() instead of reading the file directly.

.github/golden-file-updater.yml (2)

30-33: Ensure push credentials are explicit
While actions/checkout@v4 defaults to persisting GITHUB_TOKEN, it’s clearer to explicitly specify:

with:
  persist-credentials: true
  token: ${{ secrets.GITHUB_TOKEN }}

This guarantees the workflow can commit and push changes.

---

43-49: Use a non-personal identity for automated commits
Hardcoding a personal username/email can obscure audit trails. Use the GitHub Actions bot or ${{ github.actor }}, for example:

- git config user.name c985-star
- git config user.email c4746376@gmail.com
+ git config user.name "github-actions[bot]"
+ git config user.email "${{ github.actor }}@users.noreply.github.com"

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

file.py (1)

51-52: ⚠️ Potential issue

Fix critical indentation syntax error.

The indentation is incorrect and causing a syntax error that prevents the code from parsing.

Apply this diff to fix the indentation:

-          if diff_string == "":
-              return False
+        if diff_string == "":
+            return False

The lines should use 4 spaces for indentation to align with the surrounding code block.

🧰 Tools

🪛 Ruff (0.11.9)

51-51: SyntaxError: Unexpected indentation

🪛 GitHub Actions: Python package

[error] 51-51: Black formatting failed: Cannot parse code at line 51. Please fix syntax errors to allow formatting.

file.py (1)

37-48: Improve file path handling for better robustness.

Good work implementing comprehensive exception handling! However, the hardcoded relative path could fail when the function is called from different working directories.

Consider using an absolute path relative to the current file:

+        current_dir = os.path.dirname(os.path.abspath(__file__))
+        golden_file_path = os.path.join(current_dir, "tests", "no_content_template.golden")
-        try:
-            with open("tests/no_content_template.golden", "r", encoding="utf-8") as nct:
+        try:
+            with open(golden_file_path, "r", encoding="utf-8") as nct:

Additionally, consider returning a boolean or raising an exception instead of sys.exit(1) to make the function more testable and modular.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

tests/file_test.py (2)

52-68: 💡 Verification agent

🧩 Analysis chain

Critical: Test failures indicate inverted validate_url logic.

Based on the pipeline failures and PR objectives, the validate_url function has inverted logic - it currently returns False when content matches the golden template and True when it doesn't. This explains why both test cases are failing.

The test expectations are correct, but the underlying validate_url function implementation needs to be fixed to return True when content matches and False when it doesn't.

---

🏁 Script executed:

#!/bin/bash
# Verify the current validate_url implementation logic
rg -A 10 -B 2 "def validate_url" --type py

Length of output: 451

---

I’d like to inspect the full validate_url implementation to confirm its return logic.

---

🏁 Script executed:

#!/bin/bash
# Dump the full validate_url function for review
rg -A 50 "def validate_url" --type py

Length of output: 2502

---

Invert validate_url return logic

The validate_url function currently does:

# Return True if content matches template (no differences)
diff_list = list(diff)
return len(diff_list) == 0

This returns True when the page matches the “no content” template (i.e. post doesn’t exist) and False otherwise—exactly opposite of what your tests expect.

Please update the return to indicate “exists” when there are differences:

--- file.py
@@ def validate_url(url: str) -> bool:
-        diff_list = list(diff)
-        return len(diff_list) == 0  # True if no differences found
+        diff_list = list(diff)
+        return len(diff_list) != 0  # True if differences found (post exists)

Fixes the inverted logic so:

• URLs returning actual post content → True
• URLs matching the “no content” template → False

🧰 Tools

🪛 GitHub Actions: Python package

[error] 67-67: Unit test failure in test_validate_url [Post Exists]: Expected True but got False.

---

[error] 67-67: Unit test failure in test_validate_url [Post Doesn't Exist]: Expected False but got True.

---

79-119: 💡 Verification agent

🧩 Analysis chain

Address test_extract_post_data pipeline failure.

The pipeline shows this test is failing with "Expected list with post data but got empty list" for the "Contains Post Data" case. This suggests the extract_post_data function may not be processing the input data structure correctly.

---

🏁 Script executed:

#!/bin/bash
# Verify the extract_post_data function implementation
rg -A 20 -B 2 "def extract_post_data" --type py

Length of output: 1986

---

🏁 Script executed:

#!/bin/bash
# Retrieve the implementation of validate_url to understand why URLs may be filtered out
rg -A 20 "def validate_url" --type py

Length of output: 1131

---

Mock validate_url in test_extract_post_data to avoid external calls

The failure isn’t in parsing the post dict but in the URL check: extract_post_data uses validate_url(post_link) which performs a live HTTP request against a golden-file template, causing every URL to be filtered out in CI.

Please update the test so that validate_url always returns True when running test_extract_post_data. For example, in tests/file_test.py:

• Import unittest.mock.patch
• Wrap your call in a patch context (or use @patch) to stub file.validate_url:

--- a/tests/file_test.py
+++ b/tests/file_test.py
@@     def test_extract_post_data(self) -> None:
-        result = extract_post_data(case.get_data())
+        with patch("file.validate_url", return_value=True):
+            result = extract_post_data(case.get_data())
         self.assertEqual(result, case.get_expected_result())

This ensures the test focuses solely on data extraction logic and isn’t blocked by external URL validation.

🧰 Tools

🪛 GitHub Actions: Python package

[error] 118-118: Unit test failure in test_extract_post_data: Expected list with post data but got empty list.

.github/golden-file-updater.yml (2)

25-28: ⚠️ Potential issue

Critical: Fix job dependency and conditional logic.

The current structure has a fundamental flaw. The update-golden-files job will only run if run-test fails, but there's no mechanism to ensure the test actually ran and failed on the specific validation we care about.

Based on past review comments, this workflow needs proper handling of test failures. Consider:

  update-golden-files:
-  needs: run-test
-  if: needs.run-test.result == 'failure'
+    needs: run-test
+    if: always() && needs.run-test.result == 'failure'
    runs-on: ubuntu-latest

The always() ensures this job runs regardless of the previous job's outcome.

---

44-54: ⚠️ Potential issue

Critical: Fix multi-line content handling and add missing steps.

The current approach flattens multi-line content and doesn't complete the golden file update process.

    - name: Get Golden File Content with retry
      id: get_content
      run: |
        for i in {1..3}; do
-          response=$(curl -s --fail "https://bsky.app/profile/witheringtales.bsky.social/post/3legkyuzjs22") && break
+          if curl -s --fail "https://bsky.app/profile/witheringtales.bsky.social/post/3legkyuzjs22" > temp_golden.html; then
+            break
+          fi
          echo "Attempt $i failed, retrying..."
          sleep 5
        done
-        echo "response<<EOF" >> $GITHUB_OUTPUT
-        echo "$response" >> $GITHUB_OUTPUT
-        echo "EOF" >> $GITHUB_OUTPUT
+        
+    - name: Update golden file and commit
+      run: |
+        mv temp_golden.html tests/no_content_template.golden
+        git config --local user.email "action@github.com"
+        git config --local user.name "GitHub Action"
+        git add tests/no_content_template.golden
+        if git diff --staged --quiet; then
+          echo "No changes to commit"
+        else
+          git commit -m "Update golden file [skip ci]"
+          git push
+        fi

🧰 Tools

🪛 YAMLlint (1.37.1)

[error] 54-54: no new line character at the end of file

(new-line-at-end-of-file)

tests/file_test.py (1)

6-6: Remove unused import.

The os module is imported but never used in this file.

-import os

🧰 Tools

🪛 Ruff (0.11.9)

6-6: os imported but unused

Remove unused import: os

(F401)

.github/golden-file-updater.yml (2)

35-43: Fix YAML formatting issues.

Static analysis detected trailing spaces and formatting issues.

        token: ${{ secrets.GITHUB_TOKEN }}
-    
+
     - name: Validate URL before fetching
       run: |
         # Test if URL is accessible
         if ! curl --head --silent --fail "https://bsky.app/profile/witheringtales.bsky.social/post/3legkyuzjs22"; then
           echo "URL not accessible, skipping golden file update"
           exit 1
         fi
-    
+

🧰 Tools

🪛 YAMLlint (1.37.1)

[error] 35-35: trailing spaces

(trailing-spaces)

---

[error] 43-43: trailing spaces

(trailing-spaces)

---

54-54: Add missing newline at end of file.

YAML files should end with a newline character.

         echo "EOF" >> $GITHUB_OUTPUT
+

🧰 Tools

🪛 YAMLlint (1.37.1)

[error] 54-54: no new line character at the end of file

(new-line-at-end-of-file)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro